Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some cleanups in fj API #412

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Make some cleanups in fj API #412

merged 6 commits into from
Mar 29, 2022

Conversation

hannobraun
Copy link
Owner

No description provided.

The nomenclature used wasn't right. Shapes are 2D or 3D shapes, while
"objects" is a word used in the kernel code and documentation, for the
various geometric and topological elements.
This follows the style that is used in the kernel in similar situation,
which I've found advantageous, if an array is already available, with
little downside if there's not.
It's not necessary, as it's just an alias for a method that is almost as
easy to access. And it's confusing, as it implies that a sweep has its
own color that's potentially separate from the swept shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant